Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with missing policiy revision #4347

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jul 21, 2023

Done

Fixed a bug where the "Policy revision" column wasn't populated on the models page

How to QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-5188

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4347.demos.haus

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #4347 (9baa98e) into main (dd9d187) will decrease coverage by 5.48%.
The diff coverage is 5.26%.

❗ Current head 9baa98e differs from pull request most recent head d0d6da5. Consider uploading reports for the commit d0d6da5 to get more accurate results

@@            Coverage Diff             @@
##             main    #4347      +/-   ##
==========================================
- Coverage   85.85%   80.38%   -5.48%     
==========================================
  Files          95      200     +105     
  Lines        6814    10123    +3309     
  Branches        0      846     +846     
==========================================
+ Hits         5850     8137    +2287     
- Misses        964     1864     +900     
- Partials        0      122     +122     
Flag Coverage Δ
javascript 69.11% <5.26%> (?)
python 85.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/js/brand-store/components/Models/ModelsTable.tsx 23.52% <0.00%> (ø)
static/js/brand-store/components/Models/Models.tsx 42.00% <7.14%> (ø)

... and 103 files with indirect coverage changes

@Lukewh
Copy link
Contributor

Lukewh commented Jul 21, 2023

Doesn't seem to work if the latest revision is 0
image
image

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@steverydz steverydz merged commit c1ad10b into canonical:main Jul 21, 2023
8 checks passed
@steverydz steverydz deleted the models-loading-bug branch July 21, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants