Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update store api version #4342

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Update store api version #4342

merged 4 commits into from
Jul 19, 2023

Conversation

codeEmpress1
Copy link
Contributor

@codeEmpress1 codeEmpress1 commented Jul 19, 2023

Done

  • Update store api version

How to QA

Issue / Card https://warthogs.atlassian.net/browse/WD-5151

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4342.demos.haus

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4342 (3ad81f1) into main (7682768) will decrease coverage by 4.89%.
The diff coverage is 44.75%.

❗ Current head 3ad81f1 differs from pull request most recent head cd88a8e. Consider uploading reports for the commit cd88a8e to get more accurate results

@@            Coverage Diff             @@
##             main    #4342      +/-   ##
==========================================
- Coverage   85.85%   80.97%   -4.89%     
==========================================
  Files          95      198     +103     
  Lines        6814     9996    +3182     
  Branches        0      822     +822     
==========================================
+ Hits         5850     8094    +2244     
- Misses        964     1780     +816     
- Partials        0      122     +122     
Flag Coverage Δ
javascript 70.52% <44.75%> (?)
python 85.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/js/brand-store/components/Models/ModelsTable.tsx 30.76% <30.76%> (ø)
.../js/brand-store/components/Models/ModelsFilter.tsx 33.33% <33.33%> (ø)
.../brand-store/components/Models/CreateModelForm.tsx 36.36% <36.36%> (ø)
static/js/brand-store/components/Models/Models.tsx 47.61% <39.39%> (ø)
static/js/brand-store/utils/maskString.ts 91.66% <66.66%> (ø)
static/js/brand-store/selectors/index.ts 72.22% <75.00%> (ø)
static/js/brand-store/atoms/index.ts 100.00% <100.00%> (ø)
static/js/brand-store/utils/getFilteredModels.ts 100.00% <100.00%> (ø)

... and 95 files with indirect coverage changes

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit c122883 into canonical:main Jul 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants