Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy endpoints #4333

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Add policy endpoints #4333

merged 7 commits into from
Jul 12, 2023

Conversation

codeEmpress1
Copy link
Contributor

Done

  • Add the following endpoints
    • [GET] /admin/store/<store_id>/models/<model_name>/policies
    • [POST] /admin/store/<store_id>/models/<model_name>/policies

How to QA

Issue / Card https://warthogs.atlassian.net/browse/WD-4659

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4333.demos.haus

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #4333 (46e4d95) into main (cc529ab) will decrease coverage by 15.27%.
The diff coverage is n/a.

❗ Current head 46e4d95 differs from pull request most recent head 499d438. Consider uploading reports for the commit 499d438 to get more accurate results

@@             Coverage Diff             @@
##             main    #4333       +/-   ##
===========================================
- Coverage   86.83%   71.56%   -15.27%     
===========================================
  Files          95      101        +6     
  Lines        6720     3088     -3632     
  Branches        0      801      +801     
===========================================
- Hits         5835     2210     -3625     
+ Misses        885      756      -129     
- Partials        0      122      +122     
Flag Coverage Δ
javascript 71.56% <ø> (?)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 196 files with indirect coverage changes

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@codeEmpress1 codeEmpress1 merged commit bd186fc into canonical:main Jul 12, 2023
8 checks passed
@codeEmpress1 codeEmpress1 deleted the add-policy-endpoints branch July 12, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants