Add model #4332
Merged
Add model #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://snapcraft-io-4332.demos.haus |
Codecov Report
@@ Coverage Diff @@
## main #4332 +/- ##
==========================================
- Coverage 87.51% 82.02% -5.50%
==========================================
Files 95 196 +101
Lines 6656 9808 +3152
Branches 0 801 +801
==========================================
+ Hits 5825 8045 +2220
- Misses 831 1641 +810
- Partials 0 122 +122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Lukewh
reviewed
Jul 11, 2023
webapp/admin/views.py
Outdated
| res = {} | ||
| try: | ||
| models = admin_api.get_store_models(flask.session, store_id) | ||
| res["message"] = "Models retrieved" |
There was a problem hiding this comment.
If the request is successful we don't need a message :)
There was a problem hiding this comment.
For all requests? Or for the get requests only?
Lukewh
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
get_model:[GET] /admin/store/<store_id>/modelscreate_model:[POST] /admin/store/<store_id>/modelsupdate_model:[PATCH] /admin/store/<store_id>/models/<model_name>How to QA
/login-betaget_model: Go to https://snapcraft-io-4332.demos.haus/admin/store/njwQYXFnS7ppo7LaGxoh7aqVZc1CPi26/models and ensure that a response object containingmessage, success, and datais returnedpost_model: thepostendpoint can be tested by sending the request from the frontend client with payload{"name": string, "api_key": string}update_model: similar to the post endpoint should also be tested from the frontend client. payload:{"api_key": string}Issue / Card https://warthogs.atlassian.net/browse/WD-4657
NOTE
THIS ENDPOINT ONLY WORKS WHEN USER AUTHENTICATE WITH LOGIN BETA FOR NOW.
Screenshots