Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency stylelint to v15.10.1 [SECURITY] #4326

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 7, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
stylelint (source) 15.2.0 -> 15.10.1 age adoption passing confidence

GitHub Vulnerability Alerts

GHSA-f7xj-rg7h-mc87

Summary

Our meow dependency (which we use for our CLI) depended on [email protected] . A vulnerability in this version of semver was recently identified and surfaced by npm audit:

Regular Expression Denial of Service - GHSA-c2qf-rxjj-qqgw

Details

Original post by the reporter:

"my npm audit show the report

semver <7.5.2
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - GHSA-c2qf-rxjj-qqgw
No fix available

And my dependencies tree for semver show your package

├─┬ [email protected]
│ └─┬ [email protected]
│ └─┬ [email protected]
│ └─┬ [email protected]
│ └─┬ [email protected]
│ └── [email protected] deduped

I found that [email protected] contains normalize-package-data@5 and I can fix this vulnerability because it uses semver@7. But I can't update meow to the new major version because your package doesn't allow it."

Update your package to use the 'meow' version >=10"

PoC

N/A

Impact

We anticipate the impact to be low as Stylelint is a dev tool and meow is only used on the CLI pathway.


⬇️ EDITED AFTER PUBLISHED ⬇️

Security fix backported to older semver versions

The same security fix has been backported to older semver versions of 5.x and 6.x. See the CVE-2022-25883 details.

So, you can fix this vulnerability by just updating semver in your project's dependency tree, instead of updating stylelint. For details, see the example:

package.json:

{
  "dependencies": {
    "stylelint": "15.10.0"
  }
}

Run npm audit (here is no alert for semver):

$ npm ci
...

$ npm audit
...
stylelint  8.0.0 - 15.10.0
Stylelint has vulnerability in semver dependency - https://github.com/advisories/GHSA-f7xj-rg7h-mc87
fix available via `npm audit fix --force`
Will install [email protected], which is outside the stated dependency range
node_modules/stylelint

1 low severity vulnerability
...

$ npm ls semver
...
└─┬ [email protected]
  └─┬ [email protected]
    ├─┬ [email protected]
    │ └── [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └── [email protected]

Release Notes

stylelint/stylelint (stylelint)

v15.10.1

Compare Source

v15.10.0

Compare Source

v15.9.0

Compare Source

  • Added: insideFunctions: {"function": int} to number-max-precision (#​6932) (@​romainmenke).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-radius shorthand (#​6958) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-width shorthand (#​6956) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for grid-column and grid-row (#​6957) (@​mattxwang).

v15.8.0

Compare Source

v15.7.0

Compare Source

v15.6.3

Compare Source

v15.6.2

Compare Source

v15.6.1

Compare Source

v15.6.0

Compare Source

  • Added: allowEmptyInput, cache, fix options to configuration object (#​6778) (@​mattxwang).
  • Added: ignore: ["with-var-inside"] to color-function-notation (#​6802) (@​mattxwang).
  • Fixed: declaration-block-no-duplicate-properties autofix for 3 or more duplicates (#​6801) (@​mattxwang).
  • Fixed: declaration-block-no-duplicate-properties false positives with option ignore: ["consecutive-duplicates-with-different-syntaxes"] (#​6797) (@​romainmenke).
  • Fixed: declaration-block-no-duplicate-properties syntax error (#​6792) (@​yoyo837).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for grid-template (#​6777) (@​mattxwang).
  • Fixed: function-url-quotes autofix for comments in SCSS function (#​6800) (@​ybiquitous).

v15.5.0

Compare Source

v15.4.0

Compare Source

v15.3.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4326.demos.haus

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #4326 (39c229a) into main (4d28ef6) will decrease coverage by 5.08%.
The diff coverage is n/a.

❗ Current head 39c229a differs from pull request most recent head 12007e3. Consider uploading reports for the commit 12007e3 to get more accurate results

@@            Coverage Diff             @@
##             main    #4326      +/-   ##
==========================================
- Coverage   87.56%   82.49%   -5.08%     
==========================================
  Files          95      196     +101     
  Lines        6653     9741    +3088     
  Branches        0      801     +801     
==========================================
+ Hits         5826     8036    +2210     
- Misses        827     1583     +756     
- Partials        0      122     +122     
Flag Coverage Δ
javascript 71.56% <ø> (?)
python 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 101 files with indirect coverage changes

@renovate renovate bot force-pushed the renovate/npm-stylelint-vulnerability branch from a251cfa to 12007e3 Compare July 11, 2023 08:45
@steverydz steverydz merged commit edec1d9 into main Jul 12, 2023
8 checks passed
@steverydz steverydz deleted the renovate/npm-stylelint-vulnerability branch July 12, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants