Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models table #4316

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Add models table #4316

merged 1 commit into from
Jul 4, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jul 4, 2023

Done

Added the models table and filter using dummy data

How to QA

  • Go to /admin/<STORE_ID>/models
  • Check that there is a table of models
  • Check that the models table is sortable by "Name", "Last updated" and "Created date"
  • Check that the "Search models" filter works
  • Check that reloading the page with a filter that it is applied

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-4734

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #4316 (a535356) into main (3048a51) will decrease coverage by 4.94%.
The diff coverage is 85.29%.

❗ Current head a535356 differs from pull request most recent head bca8028. Consider uploading reports for the commit bca8028 to get more accurate results

@@            Coverage Diff             @@
##             main    #4316      +/-   ##
==========================================
- Coverage   87.56%   82.63%   -4.94%     
==========================================
  Files          95      189      +94     
  Lines        6653     9664    +3011     
  Branches        0      782     +782     
==========================================
+ Hits         5826     7986    +2160     
- Misses        827     1557     +730     
- Partials        0      121     +121     
Flag Coverage Δ
javascript 71.73% <85.29%> (?)
python 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
static/js/brand-store/components/Models/Models.tsx 66.66% <58.33%> (ø)
...ic/js/brand-store/components/Models/models-data.js 100.00% <100.00%> (ø)
static/js/brand-store/utils/getFilteredModels.ts 100.00% <100.00%> (ø)
static/js/brand-store/utils/maskString.ts 100.00% <100.00%> (ø)

... and 90 files with indirect coverage changes

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit 0ef4d19 into canonical:main Jul 4, 2023
8 checks passed
@steverydz steverydz deleted the models-table branch July 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants