Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for other stores in brand store #4315

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jun 30, 2023

Done

Fixed a bug where a store that includes another store will not load

How to QA

Issue / Card

Fixes #4314

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #4315 (427b897) into main (7b883af) will not change coverage.
The diff coverage is n/a.

❗ Current head 427b897 differs from pull request most recent head c23da1b. Consider uploading reports for the commit c23da1b to get more accurate results

@@           Coverage Diff           @@
##             main    #4315   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          95       95           
  Lines        6653     6653           
=======================================
  Hits         5826     5826           
  Misses        827      827           
Flag Coverage Δ
python 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@steverydz steverydz merged commit 3048a51 into canonical:main Jun 30, 2023
8 checks passed
@steverydz steverydz deleted the fix-brand-store-other-stores branch June 30, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to load brand stores that include other brand stores
2 participants