Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert brand store invites to TypeScript #4309

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jun 28, 2023

Done

How to QA

There is a bug where the modal background being confined to the table which is not related to this PR. There is an issue to fix this here (WD-4855 in Jira)

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-4851

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4309.demos.haus

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #4309 (a7ad5df) into main (5ed074c) will decrease coverage by 4.96%.
The diff coverage is 50.00%.

❗ Current head a7ad5df differs from pull request most recent head 2dfa1d6. Consider uploading reports for the commit 2dfa1d6 to get more accurate results

@@            Coverage Diff             @@
##             main    #4309      +/-   ##
==========================================
- Coverage   87.56%   82.61%   -4.96%     
==========================================
  Files          95      185      +90     
  Lines        6653     9628    +2975     
  Branches        0      770     +770     
==========================================
+ Hits         5826     7954    +2128     
- Misses        827     1553     +726     
- Partials        0      121     +121     
Flag Coverage Δ
javascript 71.52% <50.00%> (?)
python 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
static/js/brand-store/selectors/index.ts 75.00% <50.00%> (ø)

... and 89 files with indirect coverage changes

@steverydz steverydz marked this pull request as ready for review June 28, 2023 08:56
Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit 936b869 into canonical:main Jun 28, 2023
8 checks passed
@steverydz steverydz deleted the convert-invites-to-typescript branch June 28, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants