Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert brand store App component to TypeScript #4308

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jun 27, 2023

Done

Converted the brand store App component to TypeScript

How to QA

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4308.demos.haus

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #4308 (36f9921) into main (d5e9094) will decrease coverage by 4.95%.
The diff coverage is 50.00%.

❗ Current head 36f9921 differs from pull request most recent head d8b14c5. Consider uploading reports for the commit d8b14c5 to get more accurate results

@@            Coverage Diff             @@
##             main    #4308      +/-   ##
==========================================
- Coverage   87.56%   82.62%   -4.95%     
==========================================
  Files          95      185      +90     
  Lines        6653     9627    +2974     
  Branches        0      770     +770     
==========================================
+ Hits         5826     7954    +2128     
- Misses        827     1552     +725     
- Partials        0      121     +121     
Flag Coverage Δ
javascript 71.55% <50.00%> (?)
python 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
static/js/brand-store/slices/brandStoreSlice.ts 9.52% <0.00%> (ø)
static/js/brand-store/store/index.ts 100.00% <ø> (ø)
static/js/brand-store/hooks/index.ts 100.00% <100.00%> (ø)

... and 87 files with indirect coverage changes

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit 5ed074c into canonical:main Jun 27, 2023
8 checks passed
@steverydz steverydz deleted the convert-brand-store-app-component-to-typescript branch June 27, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants