Convert brand store root to TypeScript #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://snapcraft-io-4305.demos.haus |
Codecov Report
@@ Coverage Diff @@
## main #4305 +/- ##
==========================================
- Coverage 87.56% 82.62% -4.95%
==========================================
Files 95 185 +90
Lines 6653 9625 +2972
Branches 0 769 +769
==========================================
+ Hits 5826 7953 +2127
- Misses 827 1551 +724
- Partials 0 121 +121
Flags with carried forward coverage won't be shown. Click here to find out more. |
steverydz
force-pushed
the
convert-brand-store-to-typescript
branch
from
d12ef68
to
6ae0bd8
Compare
Lukewh
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Converted the brand store root file to TypeScript
How to QA