Skip to content

Commit

Permalink
Update brand store side nav (#4371)
Browse files Browse the repository at this point in the history
  • Loading branch information
steverydz authored Aug 8, 2023
1 parent 8f46b34 commit 255fdbd
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 37 deletions.
5 changes: 1 addition & 4 deletions static/js/brand-store/components/Navigation/Navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function Navigation() {
</div>

<div className="p-panel__content">
<div className="p-side-navigation--icons">
<div className="p-side-navigation">
<nav aria-label="Stores navigation">
<ul className="p-side-navigation__list">
{brandStoresList.map((item: Store) => {
Expand All @@ -64,9 +64,6 @@ function Navigation() {
className="p-side-navigation__link"
to={`/admin/${item.id}/snaps`}
>
<i className="p-side-navigation__icon p-icon--initial">
<span>{item.name.charAt(0)}</span>
</i>
<span className="p-side-navigation__label u-truncate">
{item.name}
</span>
Expand Down
14 changes: 0 additions & 14 deletions static/sass/_patterns_icons.scss
Original file line number Diff line number Diff line change
@@ -1,18 +1,4 @@
@mixin snapcraft-p-icons {
.p-icon--initial {
@extend %vf-is-bordered;
@extend %vf-bg--x-light;
@extend %small-text;

border-radius: 100%;
font-style: normal;
height: 1.5rem;
margin-bottom: 0;
text-align: center;
text-transform: uppercase;
width: 1.5rem;
}

.p-icon--snapcraft-cube {
@extend %icon;

Expand Down
19 changes: 0 additions & 19 deletions static/sass/_snapcraft_l-application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -100,25 +100,6 @@
.p-panel__logo-icon {
width: 1.5rem;
}

.p-side-navigation__link {
&.is-active,
&[aria-current="page"],
&[aria-current="true"] {
@include vf-highlight-bar(#82bfa1, left);
}
}

.p-side-navigation--icons {
.p-side-navigation__icon {
left: 1.25rem;
top: 0.25rem;
}

.p-side-navigation__link {
padding-left: 3.25rem;
}
}
}

.l-aside {
Expand Down
5 changes: 5 additions & 0 deletions static/sass/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -455,3 +455,8 @@ code {
.p-navigation__row.is-full-width {
max-width: 100%;
}

// Vanilla override
.p-panel__logo {
margin-left: 0;
}

0 comments on commit 255fdbd

Please sign in to comment.