-
Notifications
You must be signed in to change notification settings - Fork 108
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Add validation sets table (#4804)
- Loading branch information
Showing
6 changed files
with
324 additions
and
2 deletions.
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
static/js/validation-sets/hooks/__tests__/useValidationSets.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import * as ReactQuery from "react-query"; | ||
import { renderHook } from "@testing-library/react"; | ||
|
||
import useValidationSets from "../useValidationSets"; | ||
|
||
describe("useValidationSets", () => { | ||
test("Calls useQuery", () => { | ||
jest.spyOn(ReactQuery, "useQuery").mockImplementation(jest.fn()); | ||
renderHook(() => useValidationSets()); | ||
expect(ReactQuery.useQuery).toHaveBeenCalled(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import useValidationSets from "./useValidationSets"; | ||
|
||
export { useValidationSets }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import { useQuery } from "react-query"; | ||
|
||
function useValidationSets() { | ||
return useQuery({ | ||
queryKey: ["validationSets"], | ||
queryFn: async () => { | ||
const response = await fetch("/api/validation-sets"); | ||
|
||
if (!response.ok) { | ||
throw new Error("Unable to fetch validation sets"); | ||
} | ||
|
||
const validationSetsData = await response.json(); | ||
|
||
if (!validationSetsData.success) { | ||
throw new Error(validationSetsData.message); | ||
} | ||
|
||
return validationSetsData.data; | ||
}, | ||
}); | ||
} | ||
|
||
export default useValidationSets; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
168 changes: 167 additions & 1 deletion
168
static/js/validation-sets/pages/ValidationSets/ValidationSets.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
static/js/validation-sets/pages/ValidationSets/__tests__/ValidationSets.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
import { BrowserRouter, useSearchParams } from "react-router-dom"; | ||
import { QueryClient, QueryClientProvider, useQuery } from "react-query"; | ||
import { render, screen } from "@testing-library/react"; | ||
import "@testing-library/jest-dom"; | ||
|
||
import ValidationSets from "../ValidationSets"; | ||
|
||
const queryClient = new QueryClient(); | ||
|
||
const renderComponent = () => { | ||
return render( | ||
<QueryClientProvider client={queryClient}> | ||
<BrowserRouter> | ||
<ValidationSets /> | ||
</BrowserRouter> | ||
</QueryClientProvider> | ||
); | ||
}; | ||
|
||
const mockValidationSets = [ | ||
{ | ||
name: "validation-set-1", | ||
revision: 1, | ||
sequence: 1, | ||
snaps: [ | ||
{ | ||
id: "test-snap-1-id", | ||
name: "test-snap-1", | ||
}, | ||
], | ||
timestamp: "2024-08-13T09:49:18Z", | ||
}, | ||
{ | ||
name: "validation-set-2", | ||
revision: 1, | ||
sequence: 2, | ||
snaps: [ | ||
{ | ||
id: "test-snap-1-id", | ||
name: "test-snap-1", | ||
}, | ||
], | ||
timestamp: "2024-08-13T09:49:18Z", | ||
}, | ||
]; | ||
|
||
jest.mock("react-query", () => ({ | ||
...jest.requireActual("react-query"), | ||
useQuery: jest.fn(), | ||
})); | ||
|
||
jest.mock("react-router-dom", () => ({ | ||
...jest.requireActual("react-router-dom"), | ||
useSearchParams: jest.fn(), | ||
})); | ||
|
||
describe("ValidationSets", () => { | ||
test("shows loading state when fetching validation sets", () => { | ||
// @ts-ignore | ||
useQuery.mockReturnValue({ status: "loading", data: undefined }); | ||
// @ts-ignore | ||
useSearchParams.mockReturnValue([new URLSearchParams()]); | ||
renderComponent(); | ||
expect(screen.getByText(/Fetching validation sets/)).toBeInTheDocument(); | ||
}); | ||
|
||
test("shows message if no validation sets", () => { | ||
// @ts-ignore | ||
useQuery.mockReturnValue({ status: "success", data: [] }); | ||
// @ts-ignore | ||
useSearchParams.mockReturnValue([new URLSearchParams()]); | ||
renderComponent(); | ||
expect( | ||
screen.getByText(/There are no validation sets to display/) | ||
).toBeInTheDocument(); | ||
}); | ||
|
||
test("shows message when there is an error fetching validation sets", () => { | ||
// @ts-ignore | ||
useQuery.mockReturnValue({ status: "error", data: undefined }); | ||
// @ts-ignore | ||
useSearchParams.mockReturnValue([new URLSearchParams()]); | ||
renderComponent(); | ||
expect( | ||
screen.getByText(/Unable to load validation sets/) | ||
).toBeInTheDocument(); | ||
}); | ||
|
||
test("displays validation sets", () => { | ||
// @ts-ignore | ||
useQuery.mockReturnValue({ status: "success", data: mockValidationSets }); | ||
// @ts-ignore | ||
useSearchParams.mockReturnValue([new URLSearchParams()]); | ||
renderComponent(); | ||
expect(screen.getByText(mockValidationSets[0].name)).toBeInTheDocument(); | ||
expect(screen.getByText(mockValidationSets[1].name)).toBeInTheDocument(); | ||
}); | ||
|
||
test("filters validation sets based on search query", () => { | ||
// @ts-ignore | ||
useQuery.mockReturnValue({ status: "success", data: mockValidationSets }); | ||
// @ts-ignore | ||
useSearchParams.mockReturnValue([new URLSearchParams({ filter: "set-2" })]); | ||
renderComponent(); | ||
expect(screen.getByText(mockValidationSets[1].name)).toBeInTheDocument(); | ||
expect( | ||
screen.queryByText(mockValidationSets[0].name) | ||
).not.toBeInTheDocument(); | ||
}); | ||
}); |