Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make smtp charm library compatible with Python 3.8 #73

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

weiiwang01
Copy link
Contributor

Applicable spec:

Overview

Make the smtp charm library compatible with Python 3.8 to pass the interface test

Fix: canonical/charm-relation-interfaces#189

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@weiiwang01 weiiwang01 requested a review from a team as a code owner November 12, 2024 16:29
arturo-seijas
arturo-seijas previously approved these changes Nov 12, 2024
Copy link

Test coverage for 3f8e386

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
lib/charms/smtp_integrator/v0/smtp.py     130      2     22      2    97%   340, 342
src/charm.py                               82      5     26      1    94%   91-93, 102-103
src/charm_state.py                         46      0      0      0   100%
-----------------------------------------------------------------------------------
TOTAL                                     258      7     48      3    97%

Static code analysis report

Run started:2024-11-12 16:57:55.317496

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 926
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 merged commit 738fec4 into main Nov 13, 2024
22 checks passed
@weiiwang01 weiiwang01 deleted the fix-lib branch November 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface test for smtp v0 failed.
3 participants