fix: Update tensorflow-serving rock #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
force-pushed
the
fix-tf-serving-1
branch
from
5338d4b
to
95f6b00
Compare
orfeas-k
changed the title
This reverts commit 95f6b00.
DnPlas
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
This PR LGTM, I don't see any reason why #86 should block this PR from getting merged as you are not introducing changes that could affect that integration test case, in that specific assertion.
We can merge on red to unblock this task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configmap.entrypoint-service:tensorflow-servingalong with required[ args ]incommandfield to address tensorflow-serving ROCK integration tests fail #83Userockcraft-channel: latest/edgein CI (that affects the whole repo) sinceentrypoint-servicefield was introduced in 1.1.0 which is not yet published tostablerockcraft snap. Otherwise, it would fail withTests
Tests still fail due to #86. This doesn't look like a major result error and is probably related to round-offs. Thus, I suggest we merge this PR and publish manually the ROCK built in the CI. Once this is done, we 'll update the seldon-server tests accordingly.
Closes #83