Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update tensorflow-serving rock #84

Merged
merged 5 commits into from
Jan 22, 2024
Merged

fix: Update tensorflow-serving rock #84

merged 5 commits into from
Jan 22, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Jan 16, 2024

  • fix tests: Until now, tests didn't actually test the ROCK (but used the upstream image) since we didn't properly replace the server's image in the charm's configmap.
  • Add entrypoint-service:tensorflow-serving along with required [ args ] in command field to address tensorflow-serving ROCK integration tests fail #83
  • Use rockcraft-channel: latest/edge in CI (that affects the whole repo) since entrypoint-service field was introduced in 1.1.0 which is not yet published to stable rockcraft snap. Otherwise, it would fail with

Tests

Tests still fail due to #86. This doesn't look like a major result error and is probably related to round-offs. Thus, I suggest we merge this PR and publish manually the ROCK built in the CI. Once this is done, we 'll update the seldon-server tests accordingly.

Closes #83

@orfeas-k orfeas-k changed the title draft: Add entrypoint-service:tensorflow-serving fix: Update tensorflow-serving rock Jan 17, 2024
@orfeas-k orfeas-k marked this pull request as ready for review January 19, 2024 13:27
@orfeas-k orfeas-k requested a review from a team as a code owner January 19, 2024 13:27
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM, I don't see any reason why #86 should block this PR from getting merged as you are not introducing changes that could affect that integration test case, in that specific assertion.
We can merge on red to unblock this task.

@orfeas-k orfeas-k merged commit 941be9a into main Jan 22, 2024
6 of 7 checks passed
@orfeas-k orfeas-k deleted the fix-tf-serving-1 branch January 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensorflow-serving ROCK integration tests fail
2 participants