-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kf 2271 feat tensorflow serving rock #32
Conversation
canonical/seldon-core-operator#133 Summary of changes: - Initial rockcraft file and tox.ini
Summary of changes: - Added organize. - Finalized bazel build.
Summary of changes: - Initial tensorflow/serving rock.
Fails to be started by workload in integration tests:
Port is part of config for tensorflow/seving. Needs more debugging. |
@SamirPS Please review. Integration tests will be addressed in another work item that is planned next. For now just a review of the ROCK itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to improve the user experience and ensure the maintaining of this ROCK, it may be good to split the Python and Bazel steps into separate parts, if possible.
@SamirPS Installing python3.8 via packages worked fine. Ready for review. |
Design and implementation details are in canonical/seldon-core-operator#133
Summary of changes:
NOTE: This is heavy ROCK. It builds in around 2 hours on 32 core machine.
Manual testing shows that all artefacts are in place: