feat: sklearnserver integration #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of changes: - Added ROCK integrity tests. - Updated ROCK image definition. - Added tox with unit and integration tests.
ca-scribner
reviewed
May 31, 2023
ca-scribner
reviewed
May 31, 2023
ca-scribner
reviewed
May 31, 2023
ca-scribner
reviewed
May 31, 2023
added 5 commits
June 1, 2023 17:03
Summary of changes: - Addressed review comments. - Modified to run tests.
Summary of changes: - Addressed review comments. - Modified to run tests.
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
i-chvets
changed the title
i-chvets
changed the title
added 8 commits
June 1, 2023 17:14
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
Summary of changes: - Updated tox.ini to properly update configmap template.
canonical/seldon-core-operator#133 Summary of changes: - Updated rockcraft.yaml with new run-user option to run as non-root. - Updated import procedure. - Tested with integration tests on the branch.
Summary of changes: - Reverted to use of shell commands and `yq` instead of CheckRock test class from chisme package. NOTE: Use of bash shell commands significantly reduces maintability of tox.ini
ca-scribner
previously approved these changes
Jun 15, 2023
ca-scribner
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR description only contains information related to code changes and testing, if required. All detailed information about problem statement, design, implementation, technical discussions, etc. is tracked in corresponding Github issue indicated below. This will ensure that important information is reliably recorded and tracked and not scattered across PR(s).
Details
Refer to the following Github issue for more information on feature/fix that this PR is related to:
canonical/seldon-core-operator#133
Summary of changes:
NOTE: Use of bash shell commands significantly reduces maintability of tox.ini ACK: @kimwnasptd