Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sklearnserver integration #11

Merged
merged 15 commits into from
Jun 15, 2023
Merged

Conversation

i-chvets
Copy link
Contributor

@i-chvets i-chvets commented May 31, 2023

NOTE: This PR description only contains information related to code changes and testing, if required. All detailed information about problem statement, design, implementation, technical discussions, etc. is tracked in corresponding Github issue indicated below. This will ensure that important information is reliably recorded and tracked and not scattered across PR(s).

Details
Refer to the following Github issue for more information on feature/fix that this PR is related to:
canonical/seldon-core-operator#133

Summary of changes:

  • Added ROCK integrity tests.
  • Updated ROCK image definition.
  • Added tox with unit and integration tests.
  • Updated rockcraft.yaml with new run-user option to run as non-root.
  • Updated import procedure.
  • Tested with integration tests on the branch.
  • Updated tox.ini to properly update configmap template.
  • Removed old non-root user section.

NOTE: Use of bash shell commands significantly reduces maintability of tox.ini ACK: @kimwnasptd

Summary of changes:
- Added ROCK integrity tests.
- Updated ROCK image definition.
- Added tox with unit and integration tests.
@i-chvets i-chvets requested a review from a team as a code owner May 31, 2023 00:43
sklearnserver/tox.ini Outdated Show resolved Hide resolved
sklearnserver/tox.ini Outdated Show resolved Hide resolved
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, but had some suggestions on how we make this easier to reuse to minimise maintenance later

Ivan Chvets added 5 commits June 1, 2023 17:03
Summary of changes:
- Addressed review comments.
- Modified to run tests.
Summary of changes:
- Addressed review comments.
- Modified to run tests.
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
@i-chvets i-chvets changed the title feat: sklearnserver rock integration feat: sklearnserver and seldon core rocks integration Jun 1, 2023
@i-chvets i-chvets changed the title feat: sklearnserver and seldon core rocks integration feat: sklearnserver integration Jun 1, 2023
Ivan Chvets added 8 commits June 1, 2023 17:14
…al/seldonio-rocks into kf-2316-feat-sklearn-integration
Summary of changes:
- Updated tox.ini to properly update configmap template.
canonical/seldon-core-operator#133

Summary of changes:
- Updated rockcraft.yaml with new run-user option to run as non-root.
- Updated import procedure.
- Tested with integration tests on the branch.
Summary of changes:
- Reverted to use of shell commands and `yq` instead of CheckRock test
  class from chisme package.

NOTE: Use of bash shell commands significantly reduces maintability of
tox.ini
ca-scribner
ca-scribner previously approved these changes Jun 15, 2023
@i-chvets i-chvets merged commit c86a3a3 into main Jun 15, 2023
@i-chvets i-chvets deleted the kf-2316-feat-sklearn-integration branch June 15, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants