preinstall: refinements to WithAutoPCRProfile #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already skipping the lockout hierarchy auth value test during post-install because this doesn't make sense, but also skip similar tests for other hierarchies and also skip the lockout checkout and the test for sufficient number of NV counters.
This makes some changes to WithAutoPCRProfile: - It renames it to WithAutoTCGPCRProfile to make it clear that it only selects secure combinations of TCG defined PCRs. - It introduces a new option - PCRProfileOptionPermitNoSecureBootPolicyProfile, so that configurations that don't use PCR7 aren't automatically selected. If PCR7 can't be used, this flag must be supplied to unlock a secure configuration that doesn't include PCR7. - It introduces the RequiredUnsupportedPCRsError error type, returned from methods of PCRProfileAutoEnablePCRsOption to make error classification a bit easier later on.
|
This is obsolete now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Draft until #340 has landed"
This makes some changes to
WithAutoPCRProfile:WithAutoTCGPCRProfileto make it clear that it onlyselects secure combinations of TCG defined PCRs.
PCRProfileOptionPermitNoSecureBootPolicyProfile, so thatconfigurations that don't use PCR7 aren't automatically selected.
If PCR7 can't be used, this flag must be supplied to unlock a secure
configuration that doesn't include PCR7.
RequiredUnsupportedPCRsErrorerror type, returnedfrom methods of
PCRProfileAutoEnablePCRsOptionto make errorclassification a bit easier later on.