efi/internal: move to internal/efi #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow internal/efi to be used by internal/efitest in a follow-up PR, which will extend HostEnvironment with some methods that are only intended for use by efi/preinstall, and which I don't want to immediately make public - the extended HostEnvironment will be used only in unit tests, as it requires the ability to mock some low-level parts of the system, such as sysfs, cpuid and MSRs and I'm not sure if there will be a need for this to be part of the public API yet.
chrisccoulson
force-pushed
the
efi-move-internal-package
branch
from
3996d61
to
526df75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow internal/efi to be used by internal/efitest in a follow-up PR, which will extend HostEnvironment with some methods that are only intended for use by efi/preinstall, and which I don't want to immediately make public - the extended HostEnvironment will be used only in unit tests, as it requires the ability to mock some low-level parts of the system, such as sysfs, cpuid and MSRs and I'm not sure if there will be a need for this to be part of the public API yet.