efi: update go-efilib to v0.9.6 #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds profiles for PCR0 (platform firmware) and PCR2 (host firmware that runs from adapter cards or firmware that runs on embedded controllers)
This changes a few types, replaces pcrProfileFlags with pcrFlags and introduces a PCRProfileEnablePCRsOption interface which is implemented by the existing profile options and will be implemenented by a new composite option returned by the detection code.
We copy the EV_SEPARATOR events from the firmware log because it can be one of two valid values. But we should be aborting early if any of these separators indicate that an error occurred in firmware rather than continuing to build a profile.
Some newer laptops are loading endpoint management applications that are shipped with firmware and measuring these to PCR4 in the OS-present phase. This currently causes us to produce invalid profiles because everything after the separator gets dropped from the predicted measurements. A future PR will provide support for detecting compatibility for FDE, with an option for detecting and disallowing these agents. In most cases, the agents should be disabled (and it's possible to disable Absolute from userspace on Dell laptops), but we should add support here for any edge cases where these agents cannot be disabled.
This adds a new function for mocking the variable backend, which will be required in a future PR which uses new functions from go-efilib that wrap around ReadVariable but where we want to be able to override the HostEnvironment in production code.
|
Closing this because it gets updated as part of #303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Draft for now because it depends on #303)
This adds a new function for mocking the variable backend, which will
be required in a future PR which uses new functions from go-efilib that
wrap around ReadVariable, and simplifies mocking in tests quite a bit.