add support for PBKDF2 for passphrases #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
add-pbkdf2-support
branch
10 times, most recently
from
7decb61
to
9a2d46c
Compare
chrisccoulson
force-pushed
the
add-pbkdf2-support
branch
4 times, most recently
from
1746a1d
to
0cab4ed
Compare
chrisccoulson
force-pushed
the
add-pbkdf2-support
branch
from
0cab4ed
to
fe8b71d
Compare
Passphrase support currently hardcodes the use of Argon2. This adds support for specifying PBKDF2, for use in environments where FIPS140 compliance is required.
chrisccoulson
force-pushed
the
add-pbkdf2-support
branch
from
6d89a46
to
1f3ff7a
Compare
pedronis
reviewed
Sep 17, 2024
Comment on lines
+39
to
+45
| var timeExecution = func(params *Params) time.Duration { | ||
| start := time.Now() | ||
| if _, err := Key(benchmarkPassword, benchmarkSalt, params, uint(params.HashAlg.Size())); err != nil { | ||
| panic(err) | ||
| } | ||
| return time.Now().Sub(start) | ||
| } |
There was a problem hiding this comment.
this bit of code in itself is not reached by tests
There was a problem hiding this comment.
I've added a test that doesn't mock this now.
Comment on lines
+139
to
+142
| case !params.HashAlg.Available(): | ||
| return nil, errors.New("unavailable digest algorithm") | ||
| case keyLen > math.MaxInt: | ||
| return nil, errors.New("invalid key length") |
There was a problem hiding this comment.
isn't there anything to check between keyLen and HashAlg?
There was a problem hiding this comment.
There isn't really any need to do that - one could use any hash algorithm to produce a key of any length, eg, if you request a key of 64 bytes with SHA-256 as the digest and 10000 iterations, it runs 10000 iterations twice to produce 2 blocks of 32-bytes and there's nothing in the design of PBKDF2 that disallows this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passphrase support currently hardcodes the use of Argon2. This adds
support for specifying PBKDF2, for use in environments where FIPS140
compliance is required.
PBKDF2 will also be a requirement for PIN support, where Argon2
will not be an option.