Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implements a custom K8s client to catch ApiErrors centrally #463

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented Jan 23, 2025

Description

This PR implements a custom K8s client to catch ApiErrors centrally.
The idea is to use a K8s client wrapped in a decorator handling ApiErrors. New k8s_client module implements a decorator and a Metaclass which is used to create a custom K8sClient and allows applying a decorator to every method of a base class (in this case a Lightkube Client).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@Gmerold Gmerold requested a review from a team as a code owner January 23, 2025 14:45
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants