Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub App authentication #1830

Merged
merged 24 commits into from
Aug 5, 2024
Merged

GitHub App authentication #1830

merged 24 commits into from
Aug 5, 2024

Conversation

cbartz
Copy link
Collaborator

@cbartz cbartz commented Jul 31, 2024 •
edited
Loading

Applicable spec: n/a

Overview

Add authentication with GItHub Apps.

Tested the integration tests by using a test app installation with access to https://github.com/cbartz-org/cbartz-repo-policy-compliance-tests . See https://github.com/canonical/repo-policy-compliance/actions/runs/10196266512/job/28206687943

Rationale

This increases the rate limit to 15,000 reqs/hour for enterprise accounts and removes the need for a specific user to be an admin on a repo that needs to be checked (this is required for PATs as they are user-bound).

Module Changes

Checklist

  • The contributing guide was applied
  • The documentation is generated using src-docs
  • The PR is tagged with appropriate label (urgent, trivial, complex)
  • Version has been incremented on pyproject.toml and rockcraft.yaml

@cbartz cbartz added the complex label Jul 31, 2024
jdkandersson
jdkandersson reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config options look good

README.md Outdated Show resolved Hide resolved
@cbartz cbartz changed the title [WIP] GitHub App authentication GitHub App authentication Jul 31, 2024
@cbartz cbartz added the documentation Improvements or additions to documentation label Aug 1, 2024
@cbartz cbartz marked this pull request as ready for review August 1, 2024 10:46
@cbartz cbartz requested a review from a team as a code owner August 1, 2024 10:46
@cbartz cbartz requested a review from jdkandersson August 1, 2024 10:49
erinecon
erinecon previously approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amandahla
amandahla approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbartz cbartz merged commit 070afea into main Aug 5, 2024
9 checks passed
@cbartz cbartz deleted the feat/github-app-auth-ISD2110 branch August 5, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdkandersson jdkandersson jdkandersson approved these changes

@yanksyoon yanksyoon yanksyoon approved these changes

@amandahla amandahla amandahla approved these changes

@erinecon erinecon erinecon left review comments

Assignees
No one assigned
Labels
complex documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cbartz @amandahla @erinecon @yanksyoon @jdkandersson