Remove unused dependencies #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
reviewed
Jan 17, 2025
dragomirp
reviewed
Jan 17, 2025
| jinja2 = "^3.1.4" | ||
| pysyncobj = "^0.3.13" | ||
| psutil = "^6.1.1" |
There was a problem hiding this comment.
it should probably be added in those PRs
carlcsaposs-canonical
requested review from
taurus-forever,
dragomirp,
marceloneppel and
lucasgameiroborges
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
=======================================
Coverage 71.38% 71.38%
=======================================
Files 15 15
Lines 3253 3253
Branches 480 480
=======================================
Hits 2322 2322
Misses 812 812
Partials 119 119 ☔ View full report in Codecov by Sentry. |
dragomirp
reviewed
Jan 17, 2025
pyproject.toml
Outdated
| pydantic = "^1.10.19" | ||
| poetry-core = "^2.0.0" | ||
| pyOpenSSL = "^24.3.0" |
There was a problem hiding this comment.
We may need to do the charmcraft 3 migration before we can remove this.
|
depends on #719 |
marceloneppel
approved these changes
Jan 21, 2025
Removed dependencies that are unused or in the wrong dependency group
carlcsaposs-canonical
force-pushed
the
unused-deps
branch
from
fe3170a to
4527bfc
Compare
taurus-forever
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dependencies that are unused or in the wrong dependency group