-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiles' self-scraping support #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some refactoring needed
0e840f6
to
a6d8a5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
little bit of cleanup needed, rest looks ok!
Wonder if we should wait for #391 to merge first or the other way around
109c031
to
485de1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of changes necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
356e5eb
to
b8592b9
Compare
Issue
Fixes #388
Fixes #384
Solution
Add a self-scraping config if no remote parca instance is connected over
self-profiling-endpoint
Drive-bys
remove
observability_libs/juju_topology.py
fromparca_scrape.py
Testing Instructions
1.
juju deploy grafana-k8s grafana --channel edge --trust
2. Deploy this parca
parca0
3. Deploy another app
parca1
4.
juju integrate parca0 grafana:grafana-source
5.
juju integrate parca1 grafana:grafana-source
6. Open Grafana UI
7. Go to
parca0
source -> you should seeparca0
's own profiles8. Go to
parca1
source -> you should seeparca1
's own profiles9.
juju integrate parca0:self-profiling-endpoint parca1
10. Open Grafana UI
11. Go to
parca0
source -> you should not seeparca0
's own profiles12. Go to
parca1
source -> you should seeparca1
's own profiles as well asparca0
's profiles