Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set security nesting on lxd container in itest #443

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Set security nesting on lxd container in itest #443

merged 1 commit into from
Oct 10, 2024

Conversation

kelkawi-a
Copy link
Contributor

This is a follow-up PR after closing #442 .

Overview

Addresses #441 by adding an input parameter to the integration tests for enabling security nesting when building rocks.

Rationale

This is needed for rocks with nested containers (e.g. docker containers) as part of the build process.

Checklist

  • The contributing guide was applied
  • [] The PR is tagged with appropriate label (urgent, trivial, complex)

@kelkawi-a kelkawi-a requested a review from a team as a code owner October 10, 2024 08:13
@alithethird alithethird added the enhancement New feature or request label Oct 10, 2024
@arturo-seijas arturo-seijas merged commit 721ef58 into canonical:main Oct 10, 2024
72 of 81 checks passed
@kelkawi-a kelkawi-a mentioned this pull request Oct 15, 2024
Merged
@cbartz cbartz mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturo-seijas arturo-seijas arturo-seijas approved these changes

@alithethird alithethird alithethird approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelkawi-a @alithethird @arturo-seijas