Only upload images declared in metadata.yaml in the publish workflow #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merkata
previously approved these changes
Sep 4, 2023
weiiwang01
dismissed stale reviews from merkata and arturo-seijas
via
0f19fa6
arturo-seijas
approved these changes
Sep 4, 2023
|
I'm confused - the checkbox for the label being applied is checked, I don't see the label? |
Sorry, label added, thanks for pointing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current publish workflow uploads all images from the integration workflow to charmhub. This isn't suitable when charms use some images solely for integration testing.
Workflow Changes
Modify the publish workflow to upload only the image resources specified in the
metadata.yaml.Checklist
urgent,trivial,complex)