Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-run-script to the test workflow #177

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add pre-run-script to the test workflow #177

merged 1 commit into from
Jul 28, 2023

Conversation

weiiwang01
Copy link
Collaborator

No description provided.

@weiiwang01 weiiwang01 requested a review from a team as a code owner July 28, 2023 11:37
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiiwang01 weiiwang01 merged commit 253f451 into main Jul 28, 2023
53 checks passed
@weiiwang01 weiiwang01 deleted the pre-run-script branch July 28, 2023 12:05
@@ -14,6 +14,9 @@ on:
type: boolean
description: Whether to use self-hosted runners to run the jobs.
default: true
pre-run-script:
description: Path to the bash script to be run before the integration tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say "integration" test? Also, should this be documented in the readme?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is copied from the input definition of the integration test workflow. I will fix the in the next pull request, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants