Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to using the charmed-mysql snap #39

Closed
wants to merge 7 commits into from
Closed

Migrate to using the charmed-mysql snap #39

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4281065
Migrate to using the charmed-mysql snap
shayancanonical Apr 17, 2023
1dd8bb3
Upgrade charmcraft libs
shayancanonical Apr 17, 2023
f8429ee
Fix correct usage of SnapCache
shayancanonical Apr 17, 2023
b0f31ea
Change the socket locations from /tmp to /var/run/mysqlrouter in SNAP…
shayancanonical Apr 19, 2023
328121e
Fix failing unit tests and lint warnings
shayancanonical Apr 19, 2023
2cec8c2
Remove the usage of the --name flag when bootstrapping mysqlrouter
shayancanonical Apr 19, 2023
13a59c8
Address PR feedback
shayancanonical Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/charms/data_platform_libs/v0/database_provides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

"""Relation provider side abstraction for database relation.
"""[DEPRECATED] Relation provider side abstraction for database relation.

This library is a uniform interface to a selection of common database
metadata, with added custom events that add convenience to database management,
Expand Down Expand Up @@ -80,7 +80,7 @@ def _on_database_requested(self, event: DatabaseRequestedEvent) -> None:

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 2
LIBPATCH = 3

logger = logging.getLogger(__name__)

Expand Down
14 changes: 10 additions & 4 deletions lib/charms/data_platform_libs/v0/database_requires.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

"""Relation 'requires' side abstraction for database relation.
"""[DEPRECATED] Relation 'requires' side abstraction for database relation.

This library is a uniform interface to a selection of common database
metadata, with added custom events that add convenience to database management,
Expand All @@ -23,7 +23,10 @@

```python

from charms.data_platform_libs.v0.database_requires import DatabaseRequires
from charms.data_platform_libs.v0.database_requires import (
DatabaseCreatedEvent,
DatabaseRequires,
)

class ApplicationCharm(CharmBase):
# Application charm that connects to database charms.
Expand Down Expand Up @@ -84,7 +87,10 @@ def _on_database_created(self, event: DatabaseCreatedEvent) -> None:

```python

from charms.data_platform_libs.v0.database_requires import DatabaseRequires
from charms.data_platform_libs.v0.database_requires import (
DatabaseCreatedEvent,
DatabaseRequires,
)

class ApplicationCharm(CharmBase):
# Application charm that connects to database charms.
Expand Down Expand Up @@ -154,7 +160,7 @@ def _on_cluster2_database_created(self, event: DatabaseCreatedEvent) -> None:

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version.
LIBPATCH = 4
LIBPATCH = 5

logger = logging.getLogger(__name__)

Expand Down
Loading