Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4219] Fix missing kwargs in some methods #143

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

shayancanonical
Copy link
Contributor

Issue

During the lastest feature merge, we misconfigured some kwargs to various methods

Solution

Fix misconfigured kwargs

Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops

shayancanonical added a commit to canonical/mysql-router-k8s-operator that referenced this pull request Apr 30, 2024
## Issue
There are some inconsistencies with shared files with mysql-router vm
(see [PR
143](canonical/mysql-router-operator#143)

## Solution
Fix inconsistencies
@shayancanonical shayancanonical merged commit 97bf8bf into main Apr 30, 2024
30 checks passed
@shayancanonical shayancanonical deleted the fix/missing_kwargs branch April 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants