Add comment about side effect from #131 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
carlcsaposs-canonical
added a commit
to canonical/mysql-router-k8s-operator
that referenced
this pull request
Apr 26, 2024
carlcsaposs-canonical
added a commit
to canonical/opensearch-operator
that referenced
this pull request
Apr 26, 2024
shayancanonical
approved these changes
Apr 30, 2024
carlcsaposs-canonical
added a commit
to canonical/mysql-router-k8s-operator
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If snap revision is unchanged during upgrade, compatibility checks are skipped
Side effect of #131
Reported by @shayancanonical—thank you!
Solution
Accept side effect & document it