[DPE-4179, DPE-4219] Add integration test for upgrades #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
changed the title
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
taurus-forever
approved these changes
Apr 26, 2024
Comment on lines
+253
to
+265
| def get_application_name(ops_test: OpsTest, application_name_substring: str) -> str: | ||
| """Returns the name of the application with the provided application name. | ||
|
|
||
| This enables us to retrieve the name of the deployed application in an existing model. | ||
|
|
||
| Note: if multiple applications with the application name exist, | ||
| the first one found will be returned. | ||
| """ | ||
| for application in ops_test.model.applications: | ||
| if application_name_substring == application: | ||
| return application | ||
|
|
||
| return "" |
There was a problem hiding this comment.
what is the purpose of this?
to check if application is deployed? if so, can you check application in ops_test.model.applications?
There was a problem hiding this comment.
it is a helper function that is imported from mysql vm. i'd like to keep as many helpers the same as we can, so we can easily refactor them into common code in the future if necessary
This was referenced May 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We do not have integration tests for upgrade
Solution
Add integration tests