Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Update LICENSE file with correct copyright info #454

Closed
wants to merge 1 commit into from

Conversation

lucasgameiroborges
Copy link
Contributor

Issue

Substitute template in LICENSE file to accurately reflect Canonical's copyright.

Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasgameiroborges remember to explicitly select the reviewers on the PR page. It's easy to let a review fly under the radar when not selected to do it.

Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're supposed to modify the LICENSE file; I believe that template is for when you add the copyright notice to a code file

I think modifying the LICENSE file will prevent github/automated tooling from recognizing it as apache 2

@lucasgameiroborges
Copy link
Contributor Author

I don't think we're supposed to modify the LICENSE file; I believe that template is for when you add the copyright notice to a code file

I think modifying the LICENSE file will prevent github/automated tooling from recognizing it as apache 2

@carlcsaposs-canonical I think you are right here, Will loop @welpaolo @delgod and @taurus-forever in this discussion to see what they think. But I agree, now after careful read of the file itself, I don't think it's supposed to be changed.

@lucasgameiroborges
Copy link
Contributor Author

Closing this after update from legal team, see https://warthogs.atlassian.net/browse/DPE-4423

@shayancanonical shayancanonical deleted the lucas/update-license branch June 7, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants