DPE-4235, DPE-4315, DPE-3263 Common UX for replication #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
changed the title
paulomach
changed the title
dpe-4235-redo-relation-after-switchover # Conflicts: # lib/charms/data_platform_libs/v0/data_secrets.py # lib/charms/mysql/v0/async_replication.py # lib/charms/mysql/v0/mysql.py # poetry.lock
paulomach
requested review from
shayancanonical,
carlcsaposs-canonical and
taurus-forever
carlcsaposs-canonical
approved these changes
Jun 7, 2024
| @@ -87,7 +87,6 @@ show_missing = true | |||
| minversion = "6.0" | |||
| log_cli_level = "INFO" | |||
| markers = ["unstable", "juju3", "only_with_juju_secrets", "only_without_juju_secrets"] | |||
| asyncio_mode = "auto" | |||
There was a problem hiding this comment.
question: does this have any affect?
There was a problem hiding this comment.
not an observable one for now
carlcsaposs-canonical
requested changes
Jun 7, 2024
Comment on lines
-63
to
+67
| pytest-github-secrets = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.1.0", subdirectory = "python/pytest_plugins/github_secrets"} | ||
| pytest-microceph = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.1.0", subdirectory = "python/pytest_plugins/microceph"} | ||
| pytest-github-secrets = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.3.0", subdirectory = "python/pytest_plugins/github_secrets"} | ||
| pytest-microceph = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.3.0", subdirectory = "python/pytest_plugins/microceph"} | ||
| pytest-operator = "^0.28.0" | ||
| pytest-operator-cache = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.1.0", subdirectory = "python/pytest_plugins/pytest_operator_cache"} | ||
| pytest-operator-groups = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.1.0", subdirectory = "python/pytest_plugins/pytest_operator_groups"} | ||
| pytest-operator-cache = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.3.0", subdirectory = "python/pytest_plugins/pytest_operator_cache"} | ||
| pytest-operator-groups = {git = "https://github.com/canonical/data-platform-workflows", tag = "v13.3.0", subdirectory = "python/pytest_plugins/pytest_operator_groups"} |
There was a problem hiding this comment.
please keep all dpw versions in sync (workloads & packages)
compatibility not guaranteed if they are out-of-sync
carlcsaposs-canonical
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution