Skip to content

Address some review comments

Codecov / codecov/project succeeded Dec 12, 2024 in 0s

88.95% (+0.00%) compared to f01004e

View this Pull Request on Codecov

88.95% (+0.00%) compared to f01004e

Details

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (f01004e) to head (d97135f).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/platform/platform_unix.cpp 33.33% 2 Missing ⚠️
src/utils/permission_utils.cpp 94.44% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3715   +/-   ##
=======================================
  Coverage   88.94%   88.95%           
=======================================
  Files         256      257    +1     
  Lines       14584    14626   +42     
=======================================
+ Hits        12972    13010   +38     
- Misses       1612     1616    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.