Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3898 by adding -fPIC to xz-embedded #3904

Merged
1 commit merged into from
Feb 3, 2025
Merged

Conversation

ntorresalberto
Copy link
Contributor

Fix #3898 by enabling -fPIC for the 3rd-party dep xz-embedded. @ricab

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo CLA).

Thanks again @ntorresalberto! Would you mind signing the CLA using the same Github handle / same email?

On top of that, part of our CI is currently blocked for external contributions. Would you mind if I pushed your branch into our repo and opened a new PR to replace this one? You would of course retain authorship of your commits and the new PR would be attributed to you in the description.

@ntorresalberto
Copy link
Contributor Author

Sure, no problem.
I tried to sign the CLA, should I put your name as the "Canonical Project Manager or contact"?

@ricab
Copy link
Collaborator

ricab commented Jan 29, 2025

Thank you @ntorresalberto, I guess you can, if it is mandatory. It is still not passing, but that may be just because it takes some time to sync. I'll check back this afternoon and we can follow up if it still fails.

@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into canonical:main in c9f0e24 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: Linking error with libdart_ffi.so (relocation R_X86_64_32S)
2 participants