-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docs directory with starter pack content #3855
Draft
giuliazanchi
wants to merge
5
commits into
main
Choose a base branch
from
create-docs-folder-rtd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3aa3d1f
Create .readthedocs.yaml file
giuliazanchi 423891a
Adding starter pack content to docs folder
giuliazanchi 54c595e
Update Makefile to use src folder for doc files
giuliazanchi cbde909
Adding requirements.txt and updating .gitignore
giuliazanchi ebc25f9
Moved index.rst
giuliazanchi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Leave a blank line at the end of this file to support concatenation | ||
cjk | ||
cryptographically | ||
dvipng | ||
fonts | ||
freefont | ||
github | ||
GPG | ||
gyre | ||
https | ||
lang | ||
latexmk | ||
otf | ||
plantuml | ||
tex | ||
texlive | ||
TOC | ||
utils | ||
WCAG | ||
xetex | ||
xindy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/*env*/ | ||
|
||
.sphinx/venv/ | ||
.sphinx/warnings.txt | ||
.sphinx/.wordlist.dic | ||
.sphinx/.doctrees/ | ||
.sphinx/node_modules/ | ||
|
||
package*.json | ||
_build | ||
.DS_Store | ||
__pycache__ | ||
.idea/ | ||
.vscode/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# .readthedocs.yaml | ||
# Read the Docs configuration file | ||
# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details | ||
|
||
# Required | ||
version: 2 | ||
|
||
# Set the version of Python and other tools you might need | ||
build: | ||
os: ubuntu-22.04 | ||
tools: | ||
python: "3.11" | ||
jobs: | ||
pre_install: | ||
- git fetch --unshallow || true | ||
|
||
# Build documentation in the docs/ directory with Sphinx | ||
sphinx: | ||
builder: dirhtml | ||
configuration: docs/conf.py | ||
fail_on_warning: true | ||
|
||
# If using Sphinx, optionally build your docs in additional formats such as PDF | ||
formats: | ||
|
||
# Optionally declare the Python requirements required to build your docs | ||
python: | ||
install: | ||
- requirements: docs/.sphinx/requirements.txt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{ | ||
"default": false, | ||
"MD003": { | ||
"style": "atx" | ||
}, | ||
"MD013": { | ||
"code_blocks": false, | ||
"tables": false, | ||
"stern": true, | ||
"line_length": 150 | ||
}, | ||
"MD014": true, | ||
"MD018": true, | ||
"MD022": true, | ||
"MD023": true, | ||
"MD026": { | ||
"punctuation": ".,;。,;" | ||
}, | ||
"MD031": { | ||
"list_items": false | ||
}, | ||
"MD032": true, | ||
"MD035": true, | ||
"MD042": true, | ||
"MD045": true, | ||
"MD052": true | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
ACME | ||
ACME's | ||
addons | ||
AGPLv | ||
API | ||
APIs | ||
balancer | ||
Charmhub | ||
CLI | ||
DCO | ||
Diátaxis | ||
Dqlite | ||
dropdown | ||
EBS | ||
EKS | ||
enablement | ||
favicon | ||
Furo | ||
Git | ||
GitHub | ||
Grafana | ||
IAM | ||
installable | ||
JSON | ||
Juju | ||
Kubeflow | ||
Kubernetes | ||
Launchpad | ||
linter | ||
LTS | ||
LXD | ||
Makefile | ||
Makefiles | ||
Matrix | ||
Mattermost | ||
MicroCeph | ||
MicroCloud | ||
MicroOVN | ||
MyST | ||
namespace | ||
namespaces | ||
NodePort | ||
Numbat | ||
observability | ||
OEM | ||
OLM | ||
Permalink | ||
pre | ||
Quickstart | ||
ReadMe | ||
reST | ||
reStructuredText | ||
roadmap | ||
RTD | ||
subdirectories | ||
subfolders | ||
subtree | ||
TODO | ||
Ubuntu | ||
UI | ||
UUID | ||
VM | ||
webhook | ||
YAML |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,15 @@ | ||||||||
/* Only relevant for specific PDF generation issues */ | ||||||||
|
||||||||
.rubric>.hclass2 { | ||||||||
display: block; | ||||||||
font-size: 2em; | ||||||||
border-radius: .5rem; | ||||||||
font-weight: 300; | ||||||||
line-height: 1.25; | ||||||||
margin-top: 1.75rem; | ||||||||
margin-right: -0.5rem; | ||||||||
margin-bottom: 0.5rem; | ||||||||
margin-left: -0.5rem; | ||||||||
padding-left: .5rem; | ||||||||
padding-right: .5rem; | ||||||||
} | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,52 @@ | ||||||||
<header id="header" class="p-navigation"> | ||||||||
|
||||||||
<div class="p-navigation__nav" role="menubar"> | ||||||||
|
||||||||
<ul class="p-navigation__links" role="menu"> | ||||||||
|
||||||||
<li> | ||||||||
<a class="p-logo" href="https://{{ product_page }}" aria-current="page"> | ||||||||
<img src="{{ pathto(product_tag,1) }}" alt="Logo" class="p-logo-image"> | ||||||||
<div class="p-logo-text p-heading--4">{{ project }} | ||||||||
</div> | ||||||||
</a> | ||||||||
</li> | ||||||||
|
||||||||
<li class="nav-ubuntu-com"> | ||||||||
<a href="https://{{ product_page }}" class="p-navigation__link">{{ product_page }}</a> | ||||||||
</li> | ||||||||
|
||||||||
<li> | ||||||||
<a href="#" class="p-navigation__link nav-more-links">More resources</a> | ||||||||
<ul class="more-links-dropdown"> | ||||||||
|
||||||||
{% if discourse %} | ||||||||
<li> | ||||||||
<a href="{{ discourse }}" class="p-navigation__sub-link p-dropdown__link">Discourse</a> | ||||||||
</li> | ||||||||
{% endif %} | ||||||||
|
||||||||
{% if mattermost %} | ||||||||
<li> | ||||||||
<a href="{{ mattermost }}" class="p-navigation__sub-link p-dropdown__link">Mattermost</a> | ||||||||
</li> | ||||||||
{% endif %} | ||||||||
|
||||||||
{% if matrix %} | ||||||||
<li> | ||||||||
<a href="{{ matrix }}" class="p-navigation__sub-link p-dropdown__link">Matrix</a> | ||||||||
</li> | ||||||||
{% endif %} | ||||||||
|
||||||||
{% if github_url %} | ||||||||
<li> | ||||||||
<a href="{{ github_url }}" class="p-navigation__sub-link p-dropdown__link">GitHub</a> | ||||||||
</li> | ||||||||
{% endif %} | ||||||||
|
||||||||
</ul> | ||||||||
</li> | ||||||||
|
||||||||
</ul> | ||||||||
</div> | ||||||||
</header> | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
------------------------------- | ||
UBUNTU FONT LICENCE Version 1.0 | ||
------------------------------- | ||
|
||
PREAMBLE | ||
This licence allows the licensed fonts to be used, studied, modified and | ||
redistributed freely. The fonts, including any derivative works, can be | ||
bundled, embedded, and redistributed provided the terms of this licence | ||
are met. The fonts and derivatives, however, cannot be released under | ||
any other licence. The requirement for fonts to remain under this | ||
licence does not require any document created using the fonts or their | ||
derivatives to be published under this licence, as long as the primary | ||
purpose of the document is not to be a vehicle for the distribution of | ||
the fonts. | ||
|
||
DEFINITIONS | ||
"Font Software" refers to the set of files released by the Copyright | ||
Holder(s) under this licence and clearly marked as such. This may | ||
include source files, build scripts and documentation. | ||
|
||
"Original Version" refers to the collection of Font Software components | ||
as received under this licence. | ||
|
||
"Modified Version" refers to any derivative made by adding to, deleting, | ||
or substituting -- in part or in whole -- any of the components of the | ||
Original Version, by changing formats or by porting the Font Software to | ||
a new environment. | ||
|
||
"Copyright Holder(s)" refers to all individuals and companies who have a | ||
copyright ownership of the Font Software. | ||
|
||
"Substantially Changed" refers to Modified Versions which can be easily | ||
identified as dissimilar to the Font Software by users of the Font | ||
Software comparing the Original Version with the Modified Version. | ||
|
||
To "Propagate" a work means to do anything with it that, without | ||
permission, would make you directly or secondarily liable for | ||
infringement under applicable copyright law, except executing it on a | ||
computer or modifying a private copy. Propagation includes copying, | ||
distribution (with or without modification and with or without charging | ||
a redistribution fee), making available to the public, and in some | ||
countries other activities as well. | ||
|
||
PERMISSION & CONDITIONS | ||
This licence does not grant any rights under trademark law and all such | ||
rights are reserved. | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a | ||
copy of the Font Software, to propagate the Font Software, subject to | ||
the below conditions: | ||
|
||
1) Each copy of the Font Software must contain the above copyright | ||
notice and this licence. These can be included either as stand-alone | ||
text files, human-readable headers or in the appropriate machine- | ||
readable metadata fields within text or binary files as long as those | ||
fields can be easily viewed by the user. | ||
|
||
2) The font name complies with the following: | ||
(a) The Original Version must retain its name, unmodified. | ||
(b) Modified Versions which are Substantially Changed must be renamed to | ||
avoid use of the name of the Original Version or similar names entirely. | ||
(c) Modified Versions which are not Substantially Changed must be | ||
renamed to both (i) retain the name of the Original Version and (ii) add | ||
additional naming elements to distinguish the Modified Version from the | ||
Original Version. The name of such Modified Versions must be the name of | ||
the Original Version, with "derivative X" where X represents the name of | ||
the new work, appended to that name. | ||
|
||
3) The name(s) of the Copyright Holder(s) and any contributor to the | ||
Font Software shall not be used to promote, endorse or advertise any | ||
Modified Version, except (i) as required by this licence, (ii) to | ||
acknowledge the contribution(s) of the Copyright Holder(s) or (iii) with | ||
their explicit written permission. | ||
|
||
4) The Font Software, modified or unmodified, in part or in whole, must | ||
be distributed entirely under this licence, and must not be distributed | ||
under any other licence. The requirement for fonts to remain under this | ||
licence does not affect any document created using the Font Software, | ||
except any version of the Font Software extracted from a document | ||
created using the Font Software may only be distributed under this | ||
licence. | ||
|
||
TERMINATION | ||
This licence becomes null and void if any of the above conditions are | ||
not met. | ||
|
||
DISCLAIMER | ||
THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF | ||
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF | ||
COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE | ||
COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, | ||
INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL | ||
DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM OTHER | ||
DEALINGS IN THE FONT SOFTWARE. |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
#! /usr/bin/env python | ||
|
||
import requests | ||
import os | ||
|
||
DIR = os.getcwd() | ||
|
||
|
||
def main(): | ||
if os.path.exists(f"{DIR}/.sphinx/styles/Canonical"): | ||
print("Vale directory exists") | ||
else: | ||
os.makedirs(f"{DIR}/.sphinx/styles/Canonical") | ||
|
||
url = ( | ||
"https://api.github.com/repos/canonical/praecepta/" | ||
+ "contents/styles/Canonical" | ||
) | ||
r = requests.get(url) | ||
for item in r.json(): | ||
download = requests.get(item["download_url"]) | ||
file = open(".sphinx/styles/Canonical/" + item["name"], "w") | ||
file.write(download.text) | ||
file.close() | ||
|
||
if os.path.exists(f"{DIR}/.sphinx/styles/config/vocabularies/Canonical"): | ||
print("Vocab directory exists") | ||
else: | ||
os.makedirs(f"{DIR}/.sphinx/styles/config/vocabularies/Canonical") | ||
|
||
url = ( | ||
"https://api.github.com/repos/canonical/praecepta/" | ||
+ "contents/styles/config/vocabularies/Canonical" | ||
) | ||
r = requests.get(url) | ||
for item in r.json(): | ||
download = requests.get(item["download_url"]) | ||
file = open( | ||
".sphinx/styles/config/vocabularies/Canonical/" + item["name"], | ||
"w" | ||
) | ||
file.write(download.text) | ||
file.close() | ||
config = requests.get( | ||
"https://raw.githubusercontent.com/canonical/praecepta/main/vale.ini" | ||
) | ||
file = open(".sphinx/vale.ini", "w") | ||
file.write(config.text) | ||
file.close() | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reference, most of the code in
.sphinx
comes directly from the upstream starter pack.So any formatting changes like this and others below will likely be undone on subsequent updates, unless the changes are submitted upstream (if they would warrant that). I'm not sure if everyone is using the same linter, mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, as long as any code needs to be copied and adopted by a repo, it should adhere to its standards. Of course, the best would be to avoid any copying at all. If nothing else, we could have a submodule pointing to the starter pack along with the necessary links. Or, better, just clone the starter pack at build time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ricab -- I see your point. It's up to you and your team to decide what's most important to prioritise and whether this should be a blocker or an improvement to plan for later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid any misunderstanding, I did not mean to propose that a submodule- or build-based approach be implemented in this PR. I would love to see it, but I agree that can be pursued separately.
Failing that though, PRs should just comply with the norm (here and in future updates). This is a priority for sure. Which is why I don't understand the reluctance to just fix these basic things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not reluctance. The main original point I was making was that the changes being proposed needed to be considered in the context of the upstream dependency and any future updates that might override them. I think you have made some sound proposals on that and I don't object to any of these changes in the meantime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I am glad we've clarified that. Thank you again for all your involvement and help on this!