Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy paste improvements #3849

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Copy paste improvements #3849

merged 3 commits into from
Jan 14, 2025

Conversation

andrei-toterman
Copy link
Contributor

This PR adds Ctrl+Insert and Shift+Insert as copy/paste shortcuts for the terminal on Windows, as well as adding a right-click context menu in the terminal that provides copy/paste functionality.

It also refactors some of the terminal code by extracting some nested widgets into separate variables, since the nesting level was getting too big.

MULTI-1679

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (859eef1) to head (b940cde).
Report is 37 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3849   +/-   ##
=======================================
  Coverage   88.94%   88.95%           
=======================================
  Files         256      256           
  Lines       14584    14584           
=======================================
+ Hits        12972    12973    +1     
+ Misses       1612     1611    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

levkropp
levkropp previously approved these changes Dec 17, 2024
Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and working on my machine

Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything functions as expected and the code looks good! But why not add these shortcuts to other platforms?

src/client/gui/lib/platform/windows.dart Show resolved Hide resolved
Sploder12
Sploder12 previously approved these changes Dec 18, 2024
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from gui-open-shell-start-vm to main December 20, 2024 23:38
@andrei-toterman andrei-toterman dismissed stale reviews from Sploder12 and levkropp December 20, 2024 23:38

The base branch was changed.

Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrei-toterman andrei-toterman added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@andrei-toterman andrei-toterman added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@andrei-toterman andrei-toterman added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 341beb9 Jan 14, 2025
14 checks passed
@andrei-toterman andrei-toterman deleted the copy-paste-improvements branch January 14, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants