-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snapshots] Implement info --snapshots
#3259
Conversation
Add a dot at the end of options descriptions, where missing, to make them consistent with the new `--snapshots` option and follow the advise in Qt docs. Use camel case for `format_option`.
Codecov Report
@@ Coverage Diff @@
## snapshots #3259 +/- ##
=============================================
- Coverage 84.81% 84.79% -0.03%
=============================================
Files 248 248
Lines 13299 13314 +15
=============================================
+ Hits 11280 11289 +9
- Misses 2019 2025 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I execute multipass info foo foo.snapshot1 --snapshots
, snapshot1
will be included twice in the result.
Fix snapshot1 repeated in `multipass info foo foo.snapshot1 --snapshots`
Good catch @sharder996. I hope it's working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looking good now!
[snapshots] Implement `info --snapshots` r=sharder996 a=ricab
[snapshots] Implement `info --snapshots` r=sharder996 a=ricab
[snapshots] Implement `info --snapshots` r=sharder996 a=ricab
[snapshots] Implement `info --snapshots` r=sharder996 a=ricab
No description provided.