Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshots] Implement info --snapshots #3259

Merged
merged 10 commits into from
Oct 19, 2023
Merged

[snapshots] Implement info --snapshots #3259

merged 10 commits into from
Oct 19, 2023

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Oct 17, 2023

No description provided.

ricab added 5 commits October 17, 2023 18:41
Add a dot at the end of options descriptions, where missing, to make
them consistent with the new `--snapshots` option and follow the advise
in Qt docs. Use camel case for `format_option`.
@ricab ricab requested a review from sharder996 October 17, 2023 18:04
@bors bors bot changed the base branch from deprecate-info-all to snapshots October 17, 2023 18:05
@ricab ricab marked this pull request as ready for review October 17, 2023 18:11
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #3259 (fddab8d) into snapshots (638fdef) will decrease coverage by 0.03%.
Report is 1 commits behind head on snapshots.
The diff coverage is 75.00%.

@@              Coverage Diff              @@
##           snapshots    #3259      +/-   ##
=============================================
- Coverage      84.81%   84.79%   -0.03%     
=============================================
  Files            248      248              
  Lines          13299    13314      +15     
=============================================
+ Hits           11280    11289       +9     
- Misses          2019     2025       +6     
Files Coverage Δ
src/client/cli/cmd/info.cpp 91.66% <100.00%> (+0.55%) ⬆️
src/daemon/daemon.cpp 69.06% <66.66%> (-0.14%) ⬇️

Copy link
Contributor

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I execute multipass info foo foo.snapshot1 --snapshots, snapshot1 will be included twice in the result.

@ricab
Copy link
Collaborator Author

ricab commented Oct 19, 2023

Good catch @sharder996. I hope it's working now.

Copy link
Contributor

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looking good now!

@sharder996 sharder996 merged commit 17b42a9 into snapshots Oct 19, 2023
9 of 12 checks passed
@bors bors bot deleted the info--snapshots branch October 19, 2023 18:34
ricab pushed a commit that referenced this pull request Oct 25, 2023
[snapshots] Implement `info --snapshots`

r=sharder996 a=ricab
ricab pushed a commit that referenced this pull request Oct 30, 2023
[snapshots] Implement `info --snapshots`

r=sharder996 a=ricab
luis4a0 pushed a commit that referenced this pull request Nov 7, 2023
[snapshots] Implement `info --snapshots`

r=sharder996 a=ricab
luis4a0 pushed a commit that referenced this pull request Nov 7, 2023
[snapshots] Implement `info --snapshots`

r=sharder996 a=ricab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants