Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New attached windows need to be placed #3676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

New attached windows need to be placed #3676

wants to merge 1 commit into from
+54 −32

Conversation

AlanGriffiths
Copy link
Contributor

Alternative to #3675

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner November 19, 2024 10:02
@AlanGriffiths AlanGriffiths mentioned this pull request Nov 19, 2024
Open
mattkae
mattkae requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the problem that I was having with cosmic-bg because LayerSurfaceV1::configure() happens before BasicWindowManager::place_new_surface(). The surface has not yet been placed when we send the configure event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkae mattkae mattkae requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanGriffiths @mattkae