Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APIs to override decoration managers and customize decorations (Take 2) #3666

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Add APIs to override decoration managers and customize decorations (Take 2) #3666

wants to merge 27 commits into from

Commits on Nov 12, 2024

  1. Add a way to override the decoration manager

    @tarek-y-ismail
    tarek-y-ismail committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    324452d View commit details
    Browse the repository at this point in the history

  2. Expose msd::Manager through miral.

    @tarek-y-ismail
    tarek-y-ismail committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f07b887 View commit details
    Browse the repository at this point in the history

  3. Add option to use and enable/disable a custom (external) decoration 

    manager in miral-shell
    @tarek-y-ismail
    tarek-y-ismail committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3065115 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Link against miral instead of using an explicit include path 

    Co-authored-by: Alan Griffiths <[email protected]>
    @tarek-y-ismail @AlanGriffiths
    tarek-y-ismail and AlanGriffiths authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    640de3e View commit details
    Browse the repository at this point in the history

  2. Use wrappers instead of a bespoke decoration manager init. 

    Also, fix symbols.
    @tarek-y-ismail
    tarek-y-ismail committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    86720fa View commit details
    Browse the repository at this point in the history

  3. Move input event listening and resolution to InputResolver

    @tarek-y-ismail
    tarek-y-ismail committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bc4c48d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Move InputResolver::DeviceEvent out to mir::shell::decoration 

    To allow for forward declares.
    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7aeeb65 View commit details
    Browse the repository at this point in the history

  2. Expose msd::{Decoration,BasicManager} through miral interfaces

    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    266f9d5 View commit details
    Browse the repository at this point in the history

  3. Copy over all of the code needed to render the titlebar

    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5b065de View commit details
    Browse the repository at this point in the history

  4. Enable custom decorations by default for testing

    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e446979 View commit details
    Browse the repository at this point in the history

  5. Use self instead of this in DecorationBasicManager::to_adapter 

    This should guarantee that the lifetime is extended since `self` is a
shared ptr
    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9d98118 View commit details
    Browse the repository at this point in the history

  6. Expose the_buffer_allocator in mir::Server

    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    98fbb29 View commit details
    Browse the repository at this point in the history

  7. Pass mir::Server down to where decorations are created

    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6966bba View commit details
    Browse the repository at this point in the history

  8. Hook up the code needed to get input events and render a titlebar

    @tarek-y-ismail
    tarek-y-ismail committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4d36c36 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Move most rendering and setup code to DecorationAdapter

    @tarek-y-ismail
    tarek-y-ismail committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6f70331 View commit details
    Browse the repository at this point in the history

  2. Move window_state from Decoration::Self to DecorationAdapter

    @tarek-y-ismail
    tarek-y-ismail committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5a36226 View commit details
    Browse the repository at this point in the history

  3. Move Decoration::update_state to DecorationAdapter

    @tarek-y-ismail
    tarek-y-ismail committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c0faac6 View commit details
    Browse the repository at this point in the history

  4. Add window dragging

    @tarek-y-ismail
    tarek-y-ismail committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    323efed View commit details
    Browse the repository at this point in the history

  5. Split the implementation and interface in miral::Decoration 

    The implementation is now called `UserDecoration` and is implemented as
an external class in miral-shell. The interface does book keeping of the
necessary data members.
    @tarek-y-ismail
    tarek-y-ismail committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a3f4c35 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Implement window resizing and cursor image changing

    @tarek-y-ismail
    tarek-y-ismail committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    33703f0 View commit details
    Browse the repository at this point in the history

  2. Implement minimize, maximize toggle, and close buttons

    @tarek-y-ismail
    tarek-y-ismail committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    851709a View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Remove CMAKE_CURRENT_BINARY_DIR from decoration example includes

    @tarek-y-ismail
    tarek-y-ismail committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cb0a912 View commit details
    Browse the repository at this point in the history

  2. Change decoration titlebar color on focus/unfocus

    @tarek-y-ismail
    tarek-y-ismail committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d127352 View commit details
    Browse the repository at this point in the history

  3. Draw additional decoration sides. 

    Respects floating/maximized/minimized states.
    @tarek-y-ismail
    tarek-y-ismail committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    099239f View commit details
    Browse the repository at this point in the history

  4. UserDecoration colors glow up

    @tarek-y-ismail
    tarek-y-ismail committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a140ce0 View commit details
    Browse the repository at this point in the history

  5. Merge Renderer::Buffer(Stream)

    @tarek-y-ismail
    tarek-y-ismail committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    550966a View commit details
    Browse the repository at this point in the history

  6. Allow decoration authors to pass custom geometry

    @tarek-y-ismail
    tarek-y-ismail committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    fa2811d View commit details
    Browse the repository at this point in the history