Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DesktopFileManager::resolve_app_id no longer returns an app id with a .desktop file suffix #3629

Merged
merged 1 commit into from
Oct 11, 2024
Merged

DesktopFileManager::resolve_app_id no longer returns an app id with a .desktop file suffix #3629

merged 1 commit into from
Oct 11, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Oct 11, 2024 •
edited
Loading

fixes #3608

@mattkae mattkae mentioned this pull request Oct 11, 2024
Open
@mattkae mattkae marked this pull request as ready for review October 11, 2024 15:28
@mattkae mattkae requested a review from a team as a code owner October 11, 2024 15:28
@mattkae mattkae changed the title DesktopFileManager::resolve_app_id no longer returns an app id with a.desktop file suffix DesktopFileManager::resolve_app_id no longer returns an app id with a .desktop file suffix Oct 11, 2024
@AlanGriffiths
Copy link
Contributor

Interesting that the asan and asan_clang spread runs fail wlcs.WpViewporterTest.

AlanGriffiths
AlanGriffiths approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. If there's nothing to the wlcs.WpViewporterTest failures feel free to land

@mattkae mattkae disabled auto-merge October 11, 2024 18:47
@mattkae mattkae merged commit 13f43b9 into main Oct 11, 2024
51 of 62 checks passed
@mattkae mattkae deleted the bugfix/3608 branch October 11, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DesktopFileManager::resolve_app_id should not return an app id with a .desktop file suffix
2 participants
@mattkae @AlanGriffiths