Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: disable window management tests on riscv #3584

Merged
merged 1 commit into from
Sep 4, 2024
Merged

bugfix: disable window management tests on riscv #3584

merged 1 commit into from
Sep 4, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Sep 3, 2024

No description provided.

@mattkae mattkae requested a review from a team as a code owner September 3, 2024 20:16
@mattkae mattkae requested a review from Saviq September 3, 2024 20:23
@mattkae mattkae force-pushed the bugfix/disable_can_move_window_with_touch_on_riscv branch from 20499ff to 9e0d34f Compare September 3, 2024 20:39
@mattkae mattkae changed the title bugfix: disable MinimalWindowManagerTest.can_move_window_with_touch on riscv bugfix: disable MinimalWindowManagerTests on riscv Sep 3, 2024
@mattkae mattkae changed the title bugfix: disable MinimalWindowManagerTests on riscv bugfix: disable window management tests on riscv Sep 3, 2024
@mattkae mattkae force-pushed the bugfix/disable_can_move_window_with_touch_on_riscv branch from 9e0d34f to ca08722 Compare September 3, 2024 21:59
@Saviq Saviq force-pushed the bugfix/disable_can_move_window_with_touch_on_riscv branch from ca08722 to fc48b71 Compare September 4, 2024 06:49
@Saviq Saviq force-pushed the bugfix/disable_can_move_window_with_touch_on_riscv branch from fc48b71 to 284654d Compare September 4, 2024 07:05
AlanGriffiths
AlanGriffiths approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I continue to hope that one day we'll discover these failures are caused by an actual bug that can be fixed

But this is a good practical workaround

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@mattkae mattkae added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 8b942e9 Sep 4, 2024
37 checks passed
@mattkae mattkae deleted the bugfix/disable_can_move_window_with_touch_on_riscv branch September 4, 2024 11:20
AlanGriffiths pushed a commit that referenced this pull request Sep 9, 2024
@mattkae @AlanGriffiths
bugfix: disable window management tests on riscv (#3584)
e80f4bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@Saviq Saviq Awaiting requested review from Saviq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkae @AlanGriffiths @Saviq