feature: provide a way to specify an additional data source for configuration data #3478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In miracle (and probably other compositors), people may want to specify configuration options in a different format (e.g. a json file, a yaml file, etc.). To facilitate this, users should be able to specify a simple map that contains the key-value pairs that were parsed from another source.
What's new?
ConfigurationDataSource
DefaultConfiguration::set_options_map
(maybe this should be in the constructor, but the constructors were a bit large)DefaultConfiguration::parse_custom
ProgramOption::parse_map
To test
In your main runner function, do something like: