Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for satellite windows being moved when the parent moves #3062

Closed
wants to merge 1 commit into from

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Oct 4, 2023

What's new?

This is a suggestion, but I think it is correct. Satellite windows should not move with their parent, right?

To test

  • Fire up gimp with satellite windows
  • Move the main window and note that the satellites don't move as well

@AlanGriffiths
Copy link
Contributor

  1. Gimp's satellites are not being identified as mir_window_type_satellite
  2. Satellites are supposed to move with the parent

@AlanGriffiths
Copy link
Contributor

  1. Gimp's satellites are not being identified as mir_window_type_satellite

Oh, that's wrong

@AlanGriffiths AlanGriffiths reopened this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #3062 (8b443e8) into main (85bc5b0) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3062      +/-   ##
==========================================
- Coverage   77.69%   77.69%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       73409    73411       +2     
==========================================
- Hits        57037    57036       -1     
- Misses      16372    16375       +3     
Files Coverage Δ
src/miral/minimal_window_manager.cpp 63.21% <50.00%> (-0.10%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattkae
Copy link
Contributor Author

mattkae commented Oct 5, 2023

  1. Gimp's satellites are not being identified as mir_window_type_satellite

    1. Satellites are supposed to move with the parent

Interesting that satellites are supposed to move with the parent. That doesn't seem to be the behavior that other compositors (e.g. mutter) gives to gimp's windows here. Would this mean that those windows are a different type of window (not-satellite)?

@mattkae mattkae closed this Oct 5, 2023
@mattkae mattkae deleted the bugfix/gimp_satellite branch October 5, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants