Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mir shell unstable #3052

Closed
wants to merge 45 commits into from
Closed

Mir shell unstable #3052

wants to merge 45 commits into from

Conversation

AlanGriffiths
Copy link
Contributor

WIP

@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Attention: 228 lines in your changes are missing coverage. Please review.

Comparison is base (5f0ed5c) 77.78% compared to head (16d5662) 77.66%.
Report is 2 commits behind head on main.

❗ Current head 16d5662 differs from pull request most recent head be95ada. Consider uploading reports for the commit be95ada to get more accurate results

Files Patch % Lines
examples/client/mir_shell_demo.cpp 52.11% 147 Missing ⚠️
src/server/frontend_wayland/mir_shell.cpp 22.85% 54 Missing ⚠️
examples/client/wayland_runner.cpp 55.55% 24 Missing ⚠️
examples/client/make_shm_pool.c 75.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3052      +/-   ##
==========================================
- Coverage   77.78%   77.66%   -0.13%     
==========================================
  Files        1074     1068       -6     
  Lines       74916    74863      -53     
==========================================
- Hits        58275    58141     -134     
- Misses      16641    16722      +81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanGriffiths AlanGriffiths force-pushed the mir-shell branch 3 times, most recently from a3e6a3e to 893152d Compare October 5, 2023 15:42
@AlanGriffiths AlanGriffiths force-pushed the mir-shell branch 2 times, most recently from fea3102 to 2b23c88 Compare November 1, 2023 13:33
@Saviq Saviq marked this pull request as ready for review November 16, 2023 14:14
@AlanGriffiths AlanGriffiths marked this pull request as draft November 24, 2023 16:36
@AlanGriffiths AlanGriffiths changed the base branch from main to fix-dragging-satellite-windows December 1, 2023 17:35
Base automatically changed from fix-dragging-satellite-windows to main December 1, 2023 22:43
@AlanGriffiths
Copy link
Contributor Author

Superseded

@AlanGriffiths AlanGriffiths deleted the mir-shell branch August 14, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlanGriffiths AlanGriffiths

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlanGriffiths