Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scope for confusion between Tips and Gloss #3044

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

AlanGriffiths
Copy link
Contributor

@AlanGriffiths AlanGriffiths commented Sep 18, 2023

We've failed to distinguished "Gloss" and "Tip" in our window management implementation, and that's led us to labelling "Tips" mir_window_type_gloss.

Label "Tips" mir_window_type_tip correctly. (Issue about the incorrect "Gloss" implementation: #3045.)

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #3044 (ce595be) into main (7f713c7) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #3044   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files        1056     1056           
  Lines       73397    73397           
=======================================
  Hits        57031    57031           
  Misses      16366    16366           
Files Changed Coverage Δ
src/server/frontend_wayland/wl_shell.cpp 38.40% <0.00%> (ø)
src/server/frontend_xwayland/xwayland_surface.cpp 0.00% <0.00%> (ø)
src/server/frontend_wayland/xdg_shell_stable.cpp 81.28% <100.00%> (ø)
src/server/frontend_wayland/xdg_shell_v6.cpp 76.30% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattkae mattkae self-requested a review September 20, 2023 14:46
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@mattkae mattkae added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 23f7023 Sep 21, 2023
33 checks passed
@mattkae mattkae deleted the tips-are-tips branch September 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants