Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we send a configure when we resize #3042

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

AlanGriffiths
Copy link
Contributor

Checking against the size of the most recent buffer (impl->window_size) is mostly unnecessary and may be incorrect.

Unnecessary, as we already have logic in the scene to avoid sending idempotent resize notifications. (But when first sizing surfaces, we still check to avoid a redundant configure() that breaks some tests.)

It is incorrect when we've sent a configure() but not received a buffer with configured size.

Fixes: #3040

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #3042 (6b2aa78) into main (156cc32) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3042   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files        1056     1056           
  Lines       73397    73397           
=======================================
+ Hits        57030    57033    +3     
+ Misses      16367    16364    -3     
Files Changed Coverage Δ
...rver/frontend_wayland/wayland_surface_observer.cpp 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's more, this seems to avoid an extra osk/resize/redraw on startup (visible with snap set wpe-webkit-mir-kiosk url=https://google.com/).

@Saviq Saviq added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 7f713c7 Sep 18, 2023
64 of 65 checks passed
@Saviq Saviq deleted the resize-should-configure branch September 18, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window resize not always sent to clients
2 participants