Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass temporaries via initializer_list #3015

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Don't pass temporaries via initializer_list #3015

merged 1 commit into from
Aug 23, 2023

Conversation

AlanGriffiths
Copy link
Contributor

Fixes: #3014

@AlanGriffiths
Copy link
Contributor Author

This code originated with a "Fix FTBFS with g++-13", so let's first see if it builds everywhere

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #3015 (ccd433e) into main (630ae49) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3015   +/-   ##
=======================================
  Coverage   77.70%   77.71%           
=======================================
  Files        1058     1058           
  Lines       73416    73416           
=======================================
+ Hits        57051    57057    +6     
+ Misses      16365    16359    -6     
Files Changed Coverage Δ
...sts/unit-tests/input/test_touchspot_controller.cpp 98.33% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlanGriffiths AlanGriffiths marked this pull request as ready for review August 23, 2023 08:47
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@Saviq Saviq enabled auto-merge August 23, 2023 08:50
@Saviq Saviq added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit a505802 Aug 23, 2023
35 of 37 checks passed
@Saviq Saviq deleted the fix-lifetime branch August 23, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ubsan: "‘new’ of ‘initializer_list’ does not extend the lifetime"
2 participants