-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow evdi #2997
Allow evdi #2997
Conversation
Codecov Report
@@ Coverage Diff @@
## platform-API-merge #2997 +/- ##
===================================================
Coverage 77.02% 77.02%
===================================================
Files 1049 1049
Lines 72669 72666 -3
===================================================
- Hits 55970 55968 -2
+ Misses 16699 16698 -1
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
How can deleting a comment in uncovered code decrease the coverage? |
It must be something timing related: https://app.codecov.io/gh/MirServer/mir/pull/2997/indirect-changes |
d0e621d
to
3ab5a63
Compare
3ab5a63
to
6fb963c
Compare
c6d26d4
to
563f1cb
Compare
6fb963c
to
6d67195
Compare
563f1cb
to
ffdb20c
Compare
6d67195
to
d32e781
Compare
ffdb20c
to
8ecafb3
Compare
8ecafb3
to
04d6452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason not to actually merge this in now.
Empirically, the platform API branch works with evdi (modulo some display config tracking that should be fixed).
So this is a reminder to change the defaults