Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow evdi #2997

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Allow evdi #2997

merged 1 commit into from
Sep 15, 2023

Conversation

AlanGriffiths
Copy link
Contributor

Empirically, the platform API branch works with evdi (modulo some display config tracking that should be fixed).

So this is a reminder to change the defaults

@AlanGriffiths AlanGriffiths changed the base branch from main to platform-API-merge August 2, 2023 11:34
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2997 (04d6452) into platform-API-merge (3a226de) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           platform-API-merge    #2997   +/-   ##
===================================================
  Coverage               77.02%   77.02%           
===================================================
  Files                    1049     1049           
  Lines                   72669    72666    -3     
===================================================
- Hits                    55970    55968    -2     
+ Misses                  16699    16698    -1     
Files Changed Coverage Δ
src/platforms/gbm-kms/server/kms/quirks.cpp 92.85% <ø> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlanGriffiths
Copy link
Contributor Author

decrease coverage by 0.01%

How can deleting a comment in uncovered code decrease the coverage?

@Saviq
Copy link
Collaborator

Saviq commented Aug 2, 2023

How can deleting a comment in uncovered code decrease the coverage?

It must be something timing related:

https://app.codecov.io/gh/MirServer/mir/pull/2997/indirect-changes

Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no reason not to actually merge this in now.

@AlanGriffiths AlanGriffiths marked this pull request as ready for review September 15, 2023 09:27
@AlanGriffiths AlanGriffiths merged commit 3c7f555 into platform-API-merge Sep 15, 2023
33 of 35 checks passed
@AlanGriffiths AlanGriffiths deleted the platform-API-enable-evdi branch September 15, 2023 09:28
RAOF pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants