Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/wlcs: Drop frame_timestamp_increases from expected failures #2976

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

RAOF
Copy link
Contributor

@RAOF RAOF commented Jul 11, 2023

Mir has actually been sending correct (or, at least, not wildly incorrect) timestamps on frame events for quite some time, but the test itself was broken.

Now that the test is not broken (and was then fixed again), remove it from the XFAIL list so CI will pass again.

Mir has actually been sending correct (or, at least, not wildly incorrect) timestamps
on frame events for quite some time, but the test itself was broken.

Now that the test is not broken (and was then fixed *again*), remove it from
the XFAIL list so CI will pass again.
@RAOF
Copy link
Contributor Author

RAOF commented Jul 11, 2023

Before canonical/wlcs#298 lands this will have some test failures ;)

Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍

@RAOF RAOF enabled auto-merge July 13, 2023 08:08
@RAOF
Copy link
Contributor Author

RAOF commented Jul 13, 2023

Now that the WLCS fix has landed, this should be landable. Retriggering the failed builds.

@RAOF RAOF added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 047e0f6 Jul 13, 2023
19 of 21 checks passed
@RAOF RAOF deleted the drop-frame-timestamp-increases-xfail branch July 13, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants